Skip to content

feat: nginx proxy headers security fine-tuning #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 30, 2025
Merged

feat: nginx proxy headers security fine-tuning #1093

merged 8 commits into from
Oct 30, 2025
+617 −436

Conversation

@nandor-magyar
Copy link
Contributor

This way CORS remains optional.

@nandor-magyar
feat(crane): nginx proxy headers security fine-tuning
04e2c94 
Signed-off-by: Nandor Magyar <nandormagyar.it@gmail.com>
@nandor-magyar nandor-magyar requested a review from a team as a code owner September 12, 2025 15:41
@nandor-magyar nandor-magyar marked this pull request as draft September 12, 2025 15:41
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:typescript source:proto Protobuf related changes. and removed pr:feat labels Sep 12, 2025
polaroi8d
polaroi8d reviewed Sep 13, 2025
View reviewed changes
polaroi8d
polaroi8d approved these changes Sep 13, 2025
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minor review.

@m8vago m8vago self-assigned this Sep 23, 2025
@m8vago m8vago force-pushed the feat/nginx-proxy-headers branch from 8175aac to 2228bb4 Compare September 24, 2025 11:58
@m8vago m8vago marked this pull request as ready for review September 24, 2025 14:23
@m8vago m8vago changed the title feat(crane): nginx proxy headers security fine-tuning feat: nginx proxy headers security fine-tuning Sep 24, 2025
@nandor-magyar
Copy link
Contributor Author

Tested, found a minor bug, fixed. LGTM!

@m8vago m8vago merged commit 0c60bd6 into develop Oct 30, 2025
22 checks passed
@m8vago m8vago deleted the feat/nginx-proxy-headers branch October 30, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@m8vago m8vago

@nandor-magyar nandor-magyar

Labels

lang:golang lang:typescript source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nandor-magyar @polaroi8d @m8vago